util: improve styleText performance #60133
Open
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation for when to colorize or not was happening in a loop. Instead, it is now done once up front instead.
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
Oct 6, 2025
|
I think the side effect is that the input is no longer validated when colorize is disabled |
|
@marco-ippolito yes, that is correct. It is the question if we need to validate the colors if they are not used. |
I lean more on the yes we should always validate the input (that's why when I previously worked on this api I left the check in the loop) but I really dont have a strong opinion, just wanted to highlight this change |
anonrig
approved these changes
Oct 6, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60133 +/- ##
==========================================
+ Coverage 88.52% 88.53% +0.01%
==========================================
Files 703 703
Lines 207825 207807 -18
Branches 40003 40008 +5
==========================================
+ Hits 183976 183992 +16
+ Misses 15862 15815 -47
- Partials 7987 8000 +13
🚀 New features to boost your workflow:
|
ljharb
approved these changes
Oct 6, 2025
lpinca
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation for when to colorize or not was happening in a loop. Instead, it is now done once up front instead.